Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:os: Avoid setting apiEndpoint for unmanaged tests #3512

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

klutchell
Copy link
Collaborator

@klutchell klutchell commented Sep 6, 2024

When this config.json field has a value, the supervisor will treat the device as managed and will crash and start to boot loop.

On faster device-types we don't seem to notice and the tests pass by chance, but on Pi Zero and similar we consistently see ECONNRESET when hitting local SV endpoints.

Change-type: patch
See: #3510
Added-in: #2369 and #3022

Warning

This REVERTS the changes made in #3022 and we need to retest the flashing of Jetson TX2 devices.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 6, 2024 20:02 — with GitHub Actions Inactive
@acostach
Copy link
Contributor

lgtm

@klutchell klutchell temporarily deployed to balena-staging.com September 12, 2024 14:50 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 12, 2024 17:28 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 12, 2024 17:28 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 12, 2024 17:28 — with GitHub Actions Inactive
@klutchell klutchell temporarily deployed to balena-staging.com September 12, 2024 17:29 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot merged commit 71572c0 into master Sep 12, 2024
162 of 164 checks passed
@flowzone-app flowzone-app bot deleted the klutchell-patch-2 branch September 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants