Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes/kernel-balena: Avoid re-building kernel modules when not signed #3598

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Jan 16, 2025

Setting the nostamp flag to any value, even if it is an empty string, causes the kernel modules to be rebuilt, which is contrary to the documentation: https://lists.openembedded.org/g/bitbake-devel/message/12359

Let's avoid setting it altogether on kernels which are not signed, to speed up builds.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@acostach acostach requested a review from a team January 16, 2025 10:19
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com January 16, 2025 10:19 — with GitHub Actions Inactive
@floion floion had a problem deploying to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Failure
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:19 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-staging.com January 16, 2025 16:54 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 16:57 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 16:57 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 16:57 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 17:02 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 17:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 17:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 17:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 17:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com January 16, 2025 19:12 — with GitHub Actions Inactive
@acostach acostach merged commit 93cae59 into master Jan 16, 2025
160 of 162 checks passed
@acostach acostach deleted the avoid_rebuilding_kernel_modules branch January 16, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants