Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: secureboot: fix reference to unavailable kernel-module-headers #3606

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Jan 31, 2025

2.108.6 doesn't exist for generic-amd64. The tests used to still work, because we werent acually passing the version to kernel-module-build correctly, meaning that it would default to the one in the kernel-module-build project. That was fixed in 4484c59 , and now we are passing the version correctly, we're looking for a nonexistant version. Changing version to match the default.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

2.108.6 doesn't exist for generic-amd64. The tests used to still work, because we werent acually passing the version to kernel-module-build correctly, meaning that it would default to the one in the kernel-module-build project. That was fixed in 4484c59 , and now we are passing the version correctly, we're looking for a nonexistant version. Changing version to match the default.

Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
Copy link
Contributor

flowzone-app bot commented Jan 31, 2025

Website deployed to CF Pages, 👀 preview link https://a55072a9.balena-os.pages.dev

@rcooke-warwick
Copy link
Contributor Author

@flowzone-app flowzone-app bot merged commit 4c7581d into master Feb 1, 2025
158 of 162 checks passed
@flowzone-app flowzone-app bot deleted the ryan/kernel-build-haeders branch February 1, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants