Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get semantic model when it is used #563

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Get semantic model when it is used #563

merged 1 commit into from
Jan 29, 2025

Conversation

KavinduZoysa
Copy link
Contributor

nipunayf
nipunayf reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@nipunayf nipunayf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause a NPE in JsonElement getTypes(JsonElement node, String propertyKey)?

@KavinduZoysa
Copy link
Contributor Author

getTypes

For that, DataMapManager is initialized with semanticModel.

@KavinduZoysa KavinduZoysa requested a review from nipunayf January 29, 2025 10:25
@nipunayf
Copy link
Contributor

getTypes

For that, DataMapManager is initialized with semanticModel.

Could we simplify this by changing it to JsonElement getTypes(JsonElement node, String propertyKey, SemanticModel semanticModel) and removing the semantic model from the constructor?

@KavinduZoysa KavinduZoysa merged commit 27a2946 into ballerina-platform:main Jan 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipunayf nipunayf nipunayf approved these changes

@hasithaa hasithaa Awaiting requested review from hasithaa

@dulajdilshan dulajdilshan Awaiting requested review from dulajdilshan

@LakshanWeerasinghe LakshanWeerasinghe Awaiting requested review from LakshanWeerasinghe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KavinduZoysa @nipunayf