Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile time schema generation for default parameters #1586

Merged
merged 17 commits into from
Oct 16, 2023

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Sep 1, 2023

Purpose

Fixes: ballerina-platform/ballerina-library#4720

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)
  • No compiler package changes (if there are any, please update the GraphQL version in Ballerina dev tools)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (a405e7a) 86.57% compared to head (65aab2e) 86.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1586      +/-   ##
============================================
- Coverage     86.57%   86.47%   -0.10%     
- Complexity      678      762      +84     
============================================
  Files           123      129       +6     
  Lines          8810     9094     +284     
  Branches       3515     3563      +48     
============================================
+ Hits           7627     7864     +237     
- Misses          903      923      +20     
- Partials        280      307      +27     
Files Coverage Δ
.../ballerina/stdlib/graphql/commons/utils/Utils.java 77.50% <ø> (ø)
...llerina/stdlib/graphql/compiler/FinderContext.java 100.00% <100.00%> (ø)
...a/stdlib/graphql/compiler/ServiceAnalysisTask.java 97.29% <100.00%> (ø)
...ql/compiler/diagnostics/CompilationDiagnostic.java 100.00% <100.00%> (ø)
...b/graphql/compiler/diagnostics/DiagnosticCode.java 100.00% <100.00%> (ø)
...raphql/compiler/diagnostics/DiagnosticMessage.java 100.00% <100.00%> (ø)
...iler/service/validator/EntityAnnotationFinder.java 72.22% <100.00%> (-2.78%) ⬇️
...service/validator/EntityAnnotationNodeVisitor.java 84.21% <100.00%> (+8.02%) ⬆️
...vice/validator/RecordTypeDefinitionNodeFinder.java 100.00% <100.00%> (ø)
...vice/validator/ResourceConfigAnnotationFinder.java 81.25% <100.00%> (-1.11%) ⬇️
... and 8 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@ThisaruGuruge
Copy link
Member

Let's resolve the conflicts and update the PR.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@ThisaruGuruge
Copy link
Member

Shall we update the changelog? We can merge this after that.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ThisaruGuruge ThisaruGuruge merged commit 1d9b3c5 into ballerina-platform:master Oct 16, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploring Compile-Time Retrieval of Default Parameter Values to Generate GraphQL Schema
2 participants