fix: image scan issue with github branch name #2896
Conversation
|
WalkthroughThe pull request modifies three GitHub workflow files ( Changes
Sequence DiagramsequenceDiagram
participant Workflow
participant DockerBuild
participant ImageScanner
Workflow->>DockerBuild: Build Docker image
DockerBuild-->>Workflow: Generate image with commit SHA tag
Workflow->>ImageScanner: Scan image using commit SHA
ImageScanner-->>Workflow: Return scan results
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
.github/workflows/publish-kyb-app.yml (1)
Line range hint
31-35: Remove duplicate Container registry login stepThe workflow contains two identical "Log in to the Container registry" steps. The second one is redundant and can be removed.
- - name: Log in to the Container registry - uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1 - with: - registry: ${{ env.REGISTRY }} - username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }}Also applies to: 61-65
🧹 Nitpick comments (2)
.github/workflows/publish-workflows-dashboard.yml (1)
108-108: Fix spacing inconsistency in image-refThere's an inconsistent spacing after
github.shacompared to other workflow files.- image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha}}' + image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}'.github/workflows/publish-kyb-app.yml (1)
115-115: Fix spacing inconsistency in image-refThere's an inconsistent spacing after
github.shacompared to the backoffice workflow.- image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha}}' + image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/publish-backoffice.yml(3 hunks).github/workflows/publish-kyb-app.yml(3 hunks).github/workflows/publish-workflows-dashboard.yml(3 hunks)
🔇 Additional comments (1)
.github/workflows/publish-backoffice.yml (1)
67-68: LGTM! Improved image tagging and scanning stability
The changes enhance the Docker image management by:
- Adding SHA-based tags for both production and non-production builds
- Using commit SHA for image scanning instead of branch names, which provides a more stable and unique reference
This improvement helps avoid potential issues with special characters in branch names and ensures consistent image scanning.
Also applies to: 90-91, 109-109
Summary by CodeRabbit
New Features
Bug Fixes