Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filenames for windows #24

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Fix filenames for windows #24

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc68393
fix: :pencil2: Rename golden files to use an hypen instead of a semic…
MaximeRougieux Nov 14, 2023
d6e16ca
docs: :memo: Add documentation on a breaking change for v5
MaximeRougieux Nov 14, 2023
64da951
refactor: :recycle: Rename all goldens according to the new pattern
MaximeRougieux Nov 14, 2023
289f186
chore: :bookmark: Bump version to 0.5.0
MaximeRougieux Nov 15, 2023
7be2a65
docs: :memo: Give details on how to perform the migration to the new …
MaximeRougieux Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## 0.5.0

**Breaking changes**

* Remove the semi colon in golden file names to support using the package on a Windows machine.

This is a breaking change for users who have generated golden files with the previous version of the library. The golden file names will now be `preview/${windowConfig.name}-${name.snakeCase}$localSuffix.png` instead of `preview/${windowConfig.name}:${name.snakeCase}$localSuffix.png`.

To resolve this, you can either rename the golden files manually or regenerate them.
T-moz marked this conversation as resolved.
Show resolved Hide resolved

## 0.4.1

* fix: Update broken link on README.md
Expand Down
Loading