feat: add support for skipping tests based on the enforced target platform #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cteq3132
force-pushed
the
feat/add-skip-test
branch
from
49dfe22
to
52b4b43
Compare
thomascoumau
approved these changes
May 13, 2024
T-moz
approved these changes
May 18, 2024
tisohjung
reviewed
Jun 11, 2024
| /// | ||
| /// Setting [failTestOnWrongPlatform] to false will skip the test instead of | ||
| /// failing it. | ||
| void setFailTestOnWrontPlatform(bool failTestOnWrongPlatform) { |
There was a problem hiding this comment.
Suggested change
| void setFailTestOnWrontPlatform(bool failTestOnWrongPlatform) { | |
| void setFailTestOnWrongPlatform(bool failTestOnWrongPlatform) { |
tisohjung
reviewed
Jun 11, 2024
| TestWidgetsFlutterBinding.ensureInitialized(); | ||
| AdaptiveTestConfiguration.instance | ||
| ..setSkippedTestPlatform(TargetPlatform.macOS) | ||
| ..setFailTestOnWrontPlatform(false) <-- Adding this will skip the `testAdaptiveWidgets` tests if you are not running the tests on a macOS platform. |
There was a problem hiding this comment.
Suggested change
| ..setFailTestOnWrontPlatform(false) <-- Adding this will skip the `testAdaptiveWidgets` tests if you are not running the tests on a macOS platform. | |
| ..setFailTestOnWrongPlatform(false) <-- Adding this will skip the `testAdaptiveWidgets` tests if you are not running the tests on a macOS platform. |
tisohjung
reviewed
Jun 11, 2024
| Future<void> testExecutable(FutureOr<void> Function() testMain) async { | ||
| TestWidgetsFlutterBinding.ensureInitialized(); | ||
| AdaptiveTestConfiguration.instance | ||
| ..setSkippedTestPlatform(TargetPlatform.macOS) |
There was a problem hiding this comment.
setSkippedTestPlatform function doesn't seem to exist in this PR.
do you mean ..setEnforcedTestPlatform(TargetPlatform.macOS)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for skipping tests instead of failing them based on the enforced target platform defined in the
AdaptiveTestConfigurationclass.