Add pathBuilder into expectGolden tester function #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-moz
reviewed
Jul 31, 2024
| @@ -70,26 +70,26 @@ extension Adaptive on WidgetTester { | |||
| Key? | |||
| byKey, // Sometimes we want to find the widget by its unique key in the case they are multiple of the same type. | |||
| bool waitForImages = true, | |||
| String Function()? pathBuilder, | |||
There was a problem hiding this comment.
Why did you choose a function without argument for parameter, instead of a simple String? ?
Ex:
String? pathinstead of:
String Function()? pathBuilder,Also if this parameters is optional, we should add the default value in the documentation
There was a problem hiding this comment.
I did this one month ago, and I really don't remember why I used a function instead of a string.
But when I see it now, I think it is possible to use a string there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For custom paths for golden files I added pathBuilder into expectGolden tester function.