feat: add custom font icons support #28
Conversation
| /// * Create a flutter_test_config.dart file. See: | ||
| /// https://api.flutter.dev/flutter/flutter_test/flutter_test-library.html | ||
| /// * add `await loadAppFonts();` in the `testExecutable` function. | ||
| Future<void> loadAppFonts() async { |
There was a problem hiding this comment.
Le mot "app" fait un peu four tout.
- Soit on trouve un meilleure naming, genre
loadFontFromManifestou autre. - Soit on fait un breaking change. Est-ce que loadFont est encore pertinent ? Sinon est-ce qu'on a besoin de maintenir cette fonction ?
There was a problem hiding this comment.
À priori, je ne vois pas d'utilisation de loadFonts que loadAppFonts ne couvre pas ; le breaking change me semble mieux.
There was a problem hiding this comment.
@MaximeRougieux un avis sur la question?
There was a problem hiding this comment.
Go breaking change, le package est en beta donc c'est ok
| ); | ||
| final waitList = <Future<void>>[]; | ||
| for (final Map<String, dynamic> font in fontManifest) { | ||
| final fontLoader = FontLoader(font['family']); |
There was a problem hiding this comment.
I see you didn't add the function for derivedFontFamily here. Why did you miss it?
There was a problem hiding this comment.
Hi, I don't understand what you're refering to. Is derivedFontFamily a function from a package? Or is it a proposition to extract some logic?
If it is the first, can you link a doc link to the function, because I couldn't find it anywhere I looked
There was a problem hiding this comment.
It is here: font_loader.dart
Method loadAppFonts is moved from flutter_glove_box project.
Why
Inspired by Golden toolkit font_loader.dart use of
FontManifest.jsonthat references all fonts by packages inbuild/unit_test/assetsfolderUse
loadAppFontsinstead ofloadFontsorloadFontsFromPackageTodo