Skip to content

Commit

Permalink
CI: explicitly build for old Apple chips
Browse files Browse the repository at this point in the history
Github's CI infrastructure seems to have updated to new apple chips.
Thus, by default, maturin compiles packages for new apple chips when run
on macos. This commit makes sure we still also run cross compilation for
old (intel) Apple hardware.
  • Loading branch information
robamler committed Oct 23, 2024
1 parent d2c7429 commit 088257d
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -353,29 +353,30 @@ jobs:
manylinux: 2014
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13

- name: Build wheels (macos)
if: matrix.os == 'macos-latest'
- name: Build wheels (windows)
if: matrix.os == 'windows-latest'
uses: messense/maturin-action@v1
with:
command: build
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13
args: --release --strip --features pybindings -i C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-8.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-9.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-10.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-11.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-12.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-13.outputs.python-version }}\x64\python3.exe

- name: Build wheels (windows)
if: matrix.os == 'windows-latest'
- name: Build wheels for old Apple chips (macos)
if: matrix.os == 'macos-latest'
uses: messense/maturin-action@v1
with:
target: x86_64-apple-darwin
command: build
args: --release --strip --features pybindings -i C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-8.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-9.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-10.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-11.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-12.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-13.outputs.python-version }}\x64\python3.exe
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13

- name: Cross-build wheels for Apple Silicon
- name: Cross-build wheels for new Apple chips (macos)
if: matrix.os == 'macos-latest'
uses: messense/maturin-action@v1
with:
target: aarch64-apple-darwin
command: build
args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13

- name: Build universal2 wheels
- name: Build universal2 wheels (macos)
if: matrix.os == 'macos-latest'
uses: messense/maturin-action@v1
with:
Expand Down

0 comments on commit 088257d

Please sign in to comment.