Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 404 deadlock #40

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fixes 404 deadlock #40

merged 3 commits into from
Oct 23, 2023

Conversation

Peddle
Copy link
Contributor

@Peddle Peddle commented Oct 23, 2023

updates potassium so that sequence number is always incremented when a request is received regardless of what response is returned.

this resolves a bug where 404s were causing deadlocks with cherry

@Peddle Peddle changed the title DRAFT: fixes the 404 deadlock draft Fixes 404 deadlock Oct 23, 2023
@Peddle Peddle requested a review from ErikKaum October 23, 2023 17:34
Copy link
Contributor

@erik-dunteman erik-dunteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me this looks good

Copy link
Member

@ErikKaum ErikKaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Peddle Peddle force-pushed the bugfix/404-deadlock branch from 466e409 to c1b17f6 Compare October 23, 2023 17:40
@Peddle Peddle merged commit b6962c3 into main Oct 23, 2023
2 checks passed
@erik-dunteman
Copy link
Contributor

don't forget to deploy @Peddle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants