Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio Overview Dashboard #1623

Merged
merged 68 commits into from
Jan 22, 2025
Merged

Portfolio Overview Dashboard #1623

merged 68 commits into from
Jan 22, 2025

Conversation

GrandSchtroumpf
Copy link
Collaborator

fix #1593

Desktop
image
Mobile
image

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: adcf182
Status: ✅  Deploy successful!
Preview URL: https://e3bb681e.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1593.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: adcf182
Status: ✅  Deploy successful!
Preview URL: https://58adbb2b.carbon-app-blast.pages.dev
Branch Preview URL: https://issue--1593.carbon-app-blast.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: adcf182
Status: ✅  Deploy successful!
Preview URL: https://dc6b1e35.carbon-app-celo.pages.dev
Branch Preview URL: https://issue--1593.carbon-app-celo.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: adcf182
Status: ✅  Deploy successful!
Preview URL: https://7ddc0060.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1593.carbon-app-sei.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as draft January 6, 2025 14:21
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, the explore and my strategies headers look great, the slide up animation looks amazing!

Notes:

  • The MyStrategiesHeader and ExplorerHeader do not have a border as the mockup, flagging just in case this isn't what is expected
  • When picking a different currency in the MyStrategiesHeader, the value didn't match the expected conversion, for example:
    image
    image

@GrandSchtroumpf GrandSchtroumpf marked this pull request as ready for review January 21, 2025 09:00
@GrandSchtroumpf GrandSchtroumpf merged commit d2c5927 into main Jan 22, 2025
4 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1593 branch January 22, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portfolio Overview Dashboard
4 participants