checksum flashloan and target tokens #638
Conversation
| @@ -233,7 +233,6 @@ def get_tkn_symbols(flashloan_tokens, tokens: pd.DataFrame) -> List: | |||
|
|
|||
| returns: list | |||
| """ | |||
| flashloan_tokens = flashloan_tokens.split(",") | |||
There was a problem hiding this comment.
drop this because its done before this function
| flashloan_tokens = flashloan_tokens.split(",") | ||
| flashloan_tokens = [cfg.w3.to_checksum_address(x) for x in flashloan_tokens] | ||
| flt_symbols = get_tkn_symbols(flashloan_tokens=flashloan_tokens, tokens=tokens) |
There was a problem hiding this comment.
Needed to change the order here else the token symbols are fetched on the checksummed addresses
| cfg.NATIVE_GAS_TOKEN_ADDRESS in flashloan_tokens | ||
| or cfg.WRAPPED_GAS_TOKEN_ADDRESS in flashloan_tokens | ||
| cfg.NATIVE_GAS_TOKEN_ADDRESS.lower() in flashloan_tokens.lower() | ||
| or cfg.WRAPPED_GAS_TOKEN_ADDRESS.lower() in flashloan_tokens.lower() | ||
| ) |
There was a problem hiding this comment.
Since the w3 module is required for checksum, and the cfg is required to be initialized before using w3, its not as clean to checksum the flashloan_tokens AND target_tokens at this point.
i.e. if we want to checksum flashloan tokens here it can go after w3 intialized but then we also need to pass the target tokens - when we have specific functions called handle_flashloan_tokens() etc.
So if the native or wrapped gas token are not checksummed we can check for their presence with lower() instead without modifying
Improve the user experience by checksumming input tokens so they arent dropped later