feat: add apple books highlight links (implement suggestions) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absorpheus
changed the title
|
The database tests run successfully on my machine however it's failing on GitHub because test/mocks/testDatabase.sqlite is in .gitignore so it's possibly running the db tests on an outdated database. (hence the error SqliteError: table ZAEANNOTATION has no column named ZANNOTATIONLOCATION). I think the GitHub workflow is not generating the updated testDatabase.sqlite file before running npm run coverage. |
bandantonio
force-pushed
the
feature/apple-books-highlight-links
branch
from
ae82216 to
f85090b
Compare
bandantonio
requested changes
Jul 10, 2024
There was a problem hiding this comment.
@absorpheus Great work, thank you! 👏
Just one clarification left, please check.
absorpheus
changed the title
bandantonio
approved these changes
Jul 11, 2024
|
@absorpheus I will merge the changes later today as a new release version. |
|
@bandantonio You're welcome 😄 |
bandantonio
force-pushed
the
feature/apple-books-highlight-links
branch
2 times, most recently
from
ab48da7 to
1a41bb9
Compare
* refactor(core): update types, constants, schemas, seedData and methods * refactor(core): update default template to include highlight location * test(db): update migrations to enable new database tests * test: add basic highlight links tests for db * test: update mock tests, plugin docs and plugin info * docs(README): update preview screenshot to show highlight links feature * docs(README): add highlight location template variable
bandantonio
force-pushed
the
feature/apple-books-highlight-links
branch
from
1a41bb9 to
65e04ec
Compare
bandantonio
pushed a commit
that referenced
this pull request
Jul 11, 2024
* refactor(core): update types, constants, schemas, seedData and methods * refactor(core): update default template to include highlight location * test(db): update migrations to enable new database tests * test: add basic highlight links tests for db * test: update mock tests, plugin docs and plugin info * docs(README): update preview screenshot to show highlight links feature * docs(README): add highlight location template variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestions made from #24
refactor(core): update types, constants, schemas, seedData and methods
refactor(core): update default template to include highlight location
test(db): update migrations to enable new database tests
test: add basic highlight links tests for db
test: update mock tests, plugin docs and plugin info
docs(README): update preview screenshot to show highlight links feature
docs(README): add highlight location template variable