Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #18 Added Component API support to react-emoji #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vinnymac
Copy link
Contributor

@vinnymac vinnymac commented Apr 2, 2016

Tests are passing, but I haven't yet finished any new ones. Please feel free to comment and review :)

I also added some new examples to show how to use the new component.

This will be a breaking change for previous users because of the export changes.

@vinnymac vinnymac changed the title Added Component API support to react-emoji #18 Added Component API support to react-emoji Apr 2, 2016
@vinnymac vinnymac changed the title #18 Added Component API support to react-emoji fix #18 Added Component API support to react-emoji Apr 2, 2016
@banyan
Copy link
Owner

banyan commented Apr 5, 2016

This will be a breaking change for previous users because of the export changes.

I'm happy if we don't have the breaking changes. Let me just consider.

@reimertz
Copy link

I have been using this for 1 week now, works really well.

Thanks @vinnymac !

@vinnymac
Copy link
Contributor Author

@banyan I can remove the breaking change and just let users export a component via destructuring. Not certain what it would be called if we do that though. Using the word component is too vague.

@reimertz you are welcome, glad someone is using it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants