Vera - api drive key unity & cli prep #17
Conversation
organizedgrime
changed the title
organizedgrime
changed the title
Cargo.lock
Outdated
There was a problem hiding this comment.
This is partially a question for @sstelfox , how are we handling updating dependencies in our Cargo.lock it looks like the main branch had cargo update run over it since this branch diverged from it, which is essentially downgrading some of them. Do we have a process in place for when and how we update dependencies?
There was a problem hiding this comment.
We want to be able to consistently run cargo update on our dependencies and we shouldn't go backwards. Whenever there is a collision we should be able to just delete the Cargo.lock and run a fresh update.
If there is a broken version we're updating to we should pin that version and deal with fixing it in a separate PR (in practice I've never had to do this one the Rust community is pretty good about breaking changes).
We don't have an explicit update schedule. I'll perform an update usually whenever I'm adding/removign a new dependency or we get pinged about a known security vulnerability.
src/codec/crypto/nonce.rs
Outdated
| @@ -18,7 +18,7 @@ impl Nonce { | |||
| } | |||
|
|
|||
| pub fn from_bytes(data: &[u8; NONCE_LENGTH]) -> Self { | |||
| Self(data.clone()) | |||
| Self(*data) | |||
There was a problem hiding this comment.
Wow, super cool! I had no idea Copy is implemented for [T;N]
|
I've looked through all the changes in |
various modifications in preparation for the api-drive key unification merge, along w some prep for CLI stuff.
https://linear.app/banyan/issue/ENG-589/api-and-drive-key-unification