Feature: fullpath function #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I'm headed off on vacation I didn't want this PR to block you with a round of changes. I'll admit its a bit rude and I feel kinda guilty about hijacking the PR. I want to avoid deconstructing variants into invalid states, such as the root node as having a valid string representation that can't be referenced or be considered valid within the rest of the filesystem. I tweaked the loop to behave correctly without the node name always being a string. I'll take a look at the draft FUSE service shortly. |
|
No worries for the takover. I had a feeling you were going to have grievances about it. Whatever gets us there faster, I'm cool with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.