Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jscatena/vector clock types #42

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Jscatena/vector clock types #42

merged 10 commits into from
Jul 8, 2024

Conversation

jscatena88
Copy link
Contributor

No description provided.

sstelfox
sstelfox suggested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@sstelfox sstelfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good! I added some comments mostly around where data is stored but I think you nailed where snapshots need to be vs "live" clocks other than the active actor's clock.

src/codec/meta/actor_settings.rs Outdated Show resolved Hide resolved
src/codec/meta/vector_clock/clock_inner.rs Show resolved Hide resolved
src/filesystem/drive/access.rs Outdated Show resolved Hide resolved
src/filesystem/drive/inner.rs Outdated Show resolved Hide resolved
@jscatena88 jscatena88 marked this pull request as ready for review July 3, 2024 20:45
sstelfox
sstelfox suggested changes Jul 3, 2024
View reviewed changes
examples/full_fs_exercise.rs Outdated Show resolved Hide resolved
src/codec/meta/actor_settings.rs Show resolved Hide resolved
src/codec/meta/journal_checkpoint.rs Outdated Show resolved Hide resolved
@jscatena88 jscatena88 added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 5bcc637 Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstelfox sstelfox sstelfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscatena88 @sstelfox