cache cluster-registry memory based on rsr namespaces #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishantapatil3
requested review from
martonsereg,
waynz0r and
Laci21
as code owners
nishantapatil3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Contains the changes required to limit namespace cache on ResourceSyncRule
rules.match.namespacesThis PR adds the namespaces field to chart release namespace in ResourceSyncRule.
With changes in cluster-registry-controller here cisco-open/cluster-registry-controller#62
Limit caching on requiredNamespaces can be used in
spec.rules.match.namespacesWhy?
In a large cluster with many namespaces, cluster-registry can consume memory resources and reach OOMKilled state due to memory limitations. This change adds namespaces filed to RSR rule to cache on istio-operator release namespace to reduce memory consumption.
Checklist