Skip to content

Commit

Permalink
fix(docker): set ROOT_DIR var uppercase
Browse files Browse the repository at this point in the history
User-defined upper case variables are suppose to signal a user input
option. That is, the use can decide what directory to run the
container on.

Signed-off-by: Jose Martins <[email protected]>
  • Loading branch information
josecm committed Oct 26, 2023
1 parent 8750ce6 commit ba2000b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ Finally, if you prefer, you can build the container image locally by running:
make -C ci/docker build
```

In the case you want to use the locally built imaghe, or just not want to fetch
In the case you want to use the locally built image, or just not want to fetch
the latest available docker image, when invoking the Makefile you should tell it
you want to use the local image and not fetch it automatically. This is also
useful when you don't have a network connection or just want to skip that step
Expand Down
2 changes: 1 addition & 1 deletion docker/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) Bao Project and Contributors. All rights reserved

root_dir?=$(realpath ../..)
ROOT_DIR?=$(realpath ../..)

DOCKER?=$(shell which docker)
docker_repo:=baoproject/bao
Expand Down

0 comments on commit ba2000b

Please sign in to comment.