-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HIS): add GOTO his metric #76
base: wip/his-metrics
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it LGTM.
42f30c7
to
8cee013
Compare
Updated with the modifications introduced in #68 and changed the output format. @miguelafsilva5 @josecm |
3805722
to
a7e1eb5
Compare
be420a9
to
c3679fc
Compare
e298879
to
27fec24
Compare
59c0a48
to
4b66c69
Compare
27fec24
to
c1452fe
Compare
6635b68
to
929ee95
Compare
c1452fe
to
4a2edbb
Compare
Signed-off-by: Afonso Santos <[email protected]>
929ee95
to
7888c5b
Compare
Tested using the repo provided by @danielRep. From my observations, it seems to be working as intended. |
That's a corner case that the tool would not detect. For such corner cases we would need to have a specific implementation. |
This PR introduces the feature of checking the existence of a
goto
statement in a function/file.According to the HIS metrics, no
goto
statement is allowedThe
qmcalc
tool is used to check this metric.This tool only outputs the existence of a
goto
expression in the file, so our tool output won't specify the function where the expression is used, only highlighting the file where the expression is used.Edited by @danielRep :
To test with https://github.com/bao-project/bao-his-tests just run the command
make ci METRIC=goto
.Checklist: