New improved printk implementation #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecm
requested review from
ninolomata,
AfonsoSantos96 and
DavidMCerdeira
as code owners
josecm
force-pushed
the
feat/new_printk_implementation
branch
2 times, most recently
from
93edbbb to
924c4d8
Compare
DavidMCerdeira
previously approved these changes
Oct 14, 2023
|
@josecm at least one CI check is failing |
danielRep
previously approved these changes
Oct 16, 2023
A from-sratch improved implementation of printk that allows printing strings larger than the allocated print buffer. It also makes this buffer statically allocated instead of allocating it on the printing cpu stack. Finally, it removes the per-uart implementation uart_puts function as this is essnetially replicated behavior, only the uart_putc is needed. This logic is now part of the console itself. The format printf attribute is also added so that errors in the format string type identifiers are detected at compile time. Signed-off-by: Jose Martins <[email protected]>
josecm
force-pushed
the
feat/new_printk_implementation
branch
from
924c4d8 to
1201159
Compare
The error was due to an "undefined reference to __aeabi_uldivmod" error in 32-bit arm architectures since we don't link the GCC lib. I don't fully understand why this intrinsic was being invoked for one of the divisions but not for the others. Anyway, I believe I fixed this by removing the use of |
danielRep
approved these changes
Oct 18, 2023
Thanks! |
DavidMCerdeira
approved these changes
Oct 18, 2023
ninolomata
approved these changes
Oct 19, 2023
AfonsoSantos96
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quality of the previous printk implementation was less than desirable. This PR introduces a new improved, and more robust printk implementation that allows to print strings larger than the allocated print buffers and also adds the "format printf" attribute so that incorrect type identifiers in the format string are detected at compile-time.