-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guest reboot support #157
Open
josecm
wants to merge
6
commits into
main
Choose a base branch
from
feat/guest_reboot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Guest reboot support #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a cpu to enter idle state after hanlding an interrupt, while leaving the interrupt in the correct state. If this was not carried out, the cpu might not wake up on another interrupt because it is still handling the current interrupt or the same interrupt might not be triggered again. Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
DavidMCerdeira
force-pushed
the
main
branch
2 times, most recently
from
July 16, 2024 10:47
59a293c
to
8837766
Compare
danielRep
requested review from
ninolomata and
DavidMCerdeira
as code owners
September 5, 2024 10:12
danielRep
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested with the baremetal demo and it seems to be correctly working for qemu-aarch64-virt
, but for qemu-riscv64-virt
bao crashes after some reboot iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for VM reset. Guest can request a VM reset by issuing standard system calls, i.e., PSCI_RESET and SBI_SRST, for arm and risc-v systems, respectively.
It starts by adding support for allowing CPUs to go idle in the middle of an interrupt. This is necessary because CPUs will receive an IPI from the CPU that emitted the reset and will be required to go idle if they are not the VM's primary CPU.
Besides the generic VM rest logic and the arch-specific calls for requesting a reset, this PR adds arch-specific logic to reset the virtual interrupt controllers.