PSCI: fix some PSCI issues and decouple CPU standby from CPU power down #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopeixoto13
requested review from
josecm,
ninolomata,
AfonsoSantos96 and
DavidMCerdeira
as code owners
|
@Diogo21Costa could you check this is inline with your previous work in distinguishing idle cpu states? |
@josecm aside from a few minor comments, this looks good to me and is consistent with the previous work! |
josecm
reviewed
Oct 29, 2024
joaopeixoto13
force-pushed
the
fix/psci
branch
2 times, most recently
from
777cbd6 to
12c0cfd
Compare
|
@joaopeixoto13 please rebase this on main and adapt the RISC-V suspend calls |
Signed-off-by: João Peixoto <[email protected]>
joaopeixoto13
force-pushed
the
fix/psci
branch
from
12c0cfd to
080a24e
Compare
Done |
josecm
previously approved these changes
Nov 1, 2024
Decoupled the CPU idle state (now called standby) from the CPU power down state. This change allows future implementations requiring CPU standby — where the core may be needed shortly after an event — to avoid transitioning to a deeper power down state. This commit also removes the `PSCI_WAKEUP_IDLE` (or standby in this case) from `psci_wake_handlers` since the standby mode does not use the `entry_point_address` and `context_id` fields and, therefore, does not require a custom wake-up handler (e.g., psci_boot_entry). Signed-off-by: João Peixoto <[email protected]>
joaopeixoto13
force-pushed
the
fix/psci
branch
from
080a24e to
8adff24
Compare
DavidMCerdeira
approved these changes
Nov 1, 2024
josecm
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is divided into three parts: