Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculated columns improvements #2571

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

dbarashev
Copy link
Contributor

  • Calculated default columns (end date and cost) are not calculated anymore.
  • Less custom property change events when loading a project.

Update #2514

Copy link

github-actions bot commented Oct 4, 2024

Test Results

315 tests  +2   315 ✅ +2   23s ⏱️ ±0s
 83 suites ±0     0 💤 ±0 
 83 files   ±0     0 ❌ ±0 

Results for commit 99cb16d. ± Comparison against base commit f94a68b.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
net.sourceforge.ganttproject.customProperty.CustomPropertyImportTest ‑ testImportDuplicatedProperties
net.sourceforge.ganttproject.customProperty.CustomPropertyImportTest ‑ import preserves property id()
net.sourceforge.ganttproject.customProperty.CustomPropertyImportTest ‑ import triggers only one event()
net.sourceforge.ganttproject.customProperty.CustomPropertyImportTest ‑ testImportDuplicatedProperties()

♻️ This comment has been updated with latest results.

@dbarashev dbarashev merged commit 5b3cd6b into master Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant