thread: fix gcc warnings

[jobo-zt]

warning: cast from function call of type ‘int’ to non-matching type ‘void *’ [-Wbad-function-cast]

[sreimers]

Which cppcheck version/flags do you use? With v2.12.0 I can not reproduce this.

[alfredh]

here is output from cppcheck 2.13

src/base64/b64.c:35:29: warning: Either the condition '!in' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck]
 const uint8_t *in_end = in + ilen;
                            ^
src/base64/b64.c:38:6: note: Assuming that condition '!in' is not redundant
 if (!in || !out || !olen)
     ^
src/base64/b64.c:35:29: note: Null pointer addition
 const uint8_t *in_end = in + ilen;
                            ^
src/net/win32/wif.c:102:17: warning: Uninitialized variable: p [uninitvar]
 for (p = info; p; p = p->Next) {
                ^
src/net/win32/wif.c:92:23: note: Assignment 'p=info', assigned value is <Uninit>
 PIP_ADAPTER_INFO p = info;
                      ^
src/net/win32/wif.c:97:10: note: Assuming condition is false
 if (ret != ERROR_SUCCESS) {
         ^
src/net/win32/wif.c:102:17: note: Uninitialized variable: p
 for (p = info; p; p = p->Next) {
                ^
src/sipevent/sipevent.h:51:39: error: syntax error [syntaxError]
void sipnot_refresh(struct sipnot *not, uint32_t expires);

[jobo-zt]

I used gcc version 10.2.1 20210110 (Debian 10.2.1-6) In the Raspberry Pi to report this errors . not cppcheck

[alfredh]

The current code is legal and valid.

I think it is just gcc that is a bit difficult regarding this code ...

[sreimers]

Replaced by: #1093