http/request: reset body mbuf pos on re-sending #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following bug:
If a HTTP request is resent (e.g. with Authentication after a 401 response), the body of the request is not sent.
This is because in
req_body_handler
mbuf_advance(conn->body, len)
is called. Then the request is re-sent and the body size is obtained by callingmbuf_get_left(conn->body)
which is now incorrect.The fix is to reset the
mbuf
position ofconn->body
before re-sending a request.