Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls/sni: skip SNI check if we are client or server_name absent #1169

Merged
merged 1 commit into from
Jul 30, 2024
Merged

tls/sni: skip SNI check if we are client or server_name absent #1169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/tls/openssl/sni.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,12 @@ static int ssl_servername_handler(SSL *ssl, int *al, void *arg)
struct tls_cert *uc = NULL;
const char *sni;

if (!SSL_is_server(ssl))
return SSL_TLSEXT_ERR_OK;

sni = SSL_get_servername(ssl, TLSEXT_NAMETYPE_host_name);
if (!str_isset(sni)) {
*al = SSL_AD_UNRECOGNIZED_NAME;
return SSL_TLSEXT_ERR_ALERT_FATAL;
}
if (!str_isset(sni))
return SSL_TLSEXT_ERR_OK;

/* find and apply matching certificate */
uc = tls_cert_for_sni(tls, sni);
Expand Down
Loading