Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtp/sess: fix missing srate_tx locking #1231

Merged
merged 1 commit into from
Dec 11, 2024
Merged

rtp/sess: fix missing srate_tx locking #1231

merged 1 commit into from
Dec 11, 2024

Conversation

sreimers
Copy link
Member

@sreimers sreimers commented Dec 11, 2024 •
edited
Loading

Found by coverity:

CID 443862: Concurrent data access violations (MISSING_LOCK) Accessing "sess->srate_tx" without holding lock "rtcp_sess.lock". Elsewhere, "rtcp_sess.srate_tx" is written to with "rtcp_sess.lock" held 2 out of 2 times (2 of these accesses strongly imply that it is necessary).

@sreimers
rtp/sess: fix missing srate_tx locking
e4ff503 
Found by coverity:

CID 443862:  Concurrent data access violations  (MISSING_LOCK)
Accessing "sess->srate_tx" without holding lock "rtcp_sess.lock".
Elsewhere, "rtcp_sess.srate_tx" is written to with "rtcp_sess.lock" held 2 out
of 2 times (2 of these accesses strongly imply that it is necessary).
@alfredh alfredh merged commit 80b7546 into main Dec 11, 2024
38 checks passed
@alfredh alfredh deleted the rtp_sess_lock_srate branch December 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreimers @alfredh