dialog: fix rtags of forking INVITE with 100rel #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
fix_forking_100rel
branch
from
19b4512 to
9d83c63
Compare
sreimers
reviewed
Sep 7, 2023
src/sip/dialog.c
Outdated
| renc.end = 0; | ||
|
|
||
| err |= sip_msg_hdr_apply(msg, msg->req, SIP_HDR_RECORD_ROUTE, | ||
| record_route_handler, &renc) ? ENOMEM : 0; |
There was a problem hiding this comment.
Thats looks a bit strange to me. If record_route_handler returns true, ENOMEM should returned?
There was a problem hiding this comment.
Absolutely, thanks. I will still clean this up a bit, hence the draft status. I wanted to make use of the GitHub workflows to make sure the test I wrote also works on other platforms.
cspiel1
reviewed
Sep 8, 2023
cspiel1
reviewed
Sep 8, 2023
cspiel1
reviewed
Sep 8, 2023
maximilianfridrich
force-pushed
the
fix_forking_100rel
branch
from
9d83c63 to
5ea9542
Compare
maximilianfridrich
force-pushed
the
fix_forking_100rel
branch
from
5ea9542 to
caa7435
Compare
|
I had to remove the new test for retest as I was not able to write a test that would properly simulate a forked INVITE. Instead, I tested it with a SIPP scenario and the PRACKs now have the correct tags. Other than that the behavior of re stays the same regarding forked INVITES. I.e. only the first 2XX response is ACKed, subsequent ones are ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See baresip/baresip#2114.