Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtp: fix video jitter calculation and add arrival time rtp header #978

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

sreimers
Copy link
Member

@sreimers sreimers commented Oct 6, 2023

The receiver arrival time is useful for jitter handling and local playout time calculation.
Fixing video jitter by calculating only when the timestamp is different than last packet (see RTP FAQ https://www.cs.columbia.edu/~hgs/rtp/faq.html#jitter).

The arrival time is useful for jitter handling and local playout time
calculation.
@sreimers sreimers changed the title rtp: add ts_arrive header rtp: fix video jitter calculation and arrival improvements Oct 7, 2023
@sreimers sreimers changed the title rtp: fix video jitter calculation and arrival improvements rtp: fix video jitter calculation and add arrival time rtp header Oct 7, 2023
@sreimers sreimers marked this pull request as ready for review October 7, 2023 11:18
@sreimers sreimers merged commit 8549260 into main Oct 7, 2023
44 checks passed
@sreimers sreimers deleted the rtp_arrival_time branch October 7, 2023 11:20
@cspiel1
Copy link
Collaborator

cspiel1 commented Oct 9, 2023

Ah, maybe we should use the rtp_source->jitter in jbuf and move the ajb (adaptive jitter buffer) from aubuf to jbuf. This would reduce the overall latency.

@sreimers
Copy link
Member Author

sreimers commented Oct 9, 2023

I'm currently working on a clock based playout time approach here (very early stage, not fully implemented):

baresip/baresip@3faa163

It's based on suggestions from this book: https://csperkins.org/standards/rtp-book.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants