Fixes issue #221

barnybug · May 6, 2017 · c758f26 · c758f26
1 parent e8ba6f4
commit c758f26
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.8.8 (2017-05-06)
+
+- Fix shortenName overzealously removes suffixes #221
+
 ## 0.8.7 (2016-11-22)
 
 - Lowercase record names to make imports case-insensitive. Fixes #206

diff --git a/main.go b/main.go
@@ -9,7 +9,7 @@ import (
 )
 
 var r53 *route53.Route53
-var version = "0.8.7"
+var version = "0.8.8"
 
 // Main entry point for cli53 application
 func Main(args []string) int {

diff --git a/util.go b/util.go
@@ -149,11 +149,8 @@ func waitForChange(change *route53.ChangeInfo) {
 func shortenName(name, origin string) string {
 	if name == origin {
 		return "@"
-	} else if strings.HasSuffix(name, origin) {
-		return name[0 : len(name)-len(origin)-1]
-	} else {
-		return name
 	}
+	return strings.TrimSuffix(name, "."+origin)
 }
 
 var reQuotedValue = regexp.MustCompile(`"((?:\\"|[^"])*)"`)

diff --git a/util_test.go b/util_test.go
@@ -90,4 +90,5 @@ func TestShortenName(t *testing.T) {
 	assert.Equal(t, "a", shortenName("a.example.com.", "example.com."))
 	assert.Equal(t, "a.", shortenName("a.", "example.com."))
 	assert.Equal(t, "a.b", shortenName("a.b.example.com.", "example.com."))
+	assert.Equal(t, "fineexample.com.", shortenName("fineexample.com.", "example.com."))
 }