security/device_cgroup: Fix RCU_LOCKDEP_WARN() condition

f78f5b9 ("rcu: Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN()") introduced a bug by incorrectly inverting the condition when moving from rcu_lockdep_assert() to RCU_LOCKDEP_WARN(). This commit therefore fixes the inversion. Reported-by: Felipe Balbi <[email protected]> Reported-by: Tejun Heo <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]> Acked-by: Serge Hallyn <[email protected]> Tested-by: Josh Boyer <[email protected]>
barondai · Sep 4, 2015 · dc3a04d · dc3a04d
1 parent 12d560f
commit dc3a04d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
@@ -401,7 +401,7 @@ static bool verify_new_ex(struct dev_cgroup *dev_cgroup,
 	bool match = false;
 
 	RCU_LOCKDEP_WARN(!rcu_read_lock_held() &&
-			 lockdep_is_held(&devcgroup_mutex),
+			 !lockdep_is_held(&devcgroup_mutex),
 			 "device_cgroup:verify_new_ex called without proper synchronization");
 
 	if (dev_cgroup->behavior == DEVCG_DEFAULT_ALLOW) {