Skip to content

Commit

Permalink
Test against php 8.4 (#1066)
Browse files Browse the repository at this point in the history
* Test against php 8.4

* Test against php 8.4

* Parameter is implicitly nullable via default value null
  • Loading branch information
sergiy-petrov authored Oct 30, 2024
1 parent 48c3ed8 commit d2b3a15
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/run-static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]
laravel: [9.*, 10.*, 11.*]
dependency-version: [prefer-stable]
exclude:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]
laravel: ['9.*', '10.*', '11.*']
dependency-version: [prefer-lowest, prefer-stable]
exclude:
Expand Down
2 changes: 1 addition & 1 deletion src/PDF.php
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function output(array $options = []): string
/**
* Save the PDF to a file
*/
public function save(string $filename, string $disk = null): self
public function save(string $filename, ?string $disk = null): self
{
$disk = $disk ?: $this->config->get('dompdf.disk');

Expand Down

0 comments on commit d2b3a15

Please sign in to comment.