Fix AggsProxy import with elasticsearch-dsl team approach #319
+38
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerf
changed the title
This was referenced Nov 24, 2024
Open
millerf
force-pushed
the
fix/aggs-proxy-import-error
branch
from
f745fc6 to
276280e
Compare
|
There is some work needed to properly fix it, however I don't know enough of this plugin to properly do that. |
srfonso
added a commit
to srfonso/django-elasticsearch-dsl-drf
that referenced
this pull request
Dec 12, 2024
Fix AggsProxy import with elasticsearch-dsl team approach barseghyanartur#319
|
Great working on my side. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment by @miguelgrinberg (elasticsearch-dsl team @ Elastic).
This PR fixes the import issue in a future-proof way, while still being backward compatible.
Testing instructions:
Run the server or some tests and verify it works.
Should fix #314 and close #315 #316 #318 (that took the same non-future-proof approach)