Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows support #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sheikhmishar
Copy link

I have tried using this awesome logging utility on linux. It works flawlessly. However, sometimes I have to use Windows PCs and that's all I have in those moments. Added some exception handling to handle some unimplemented features in Windows kernel. Also, added an easy instruction for Windows in README.md

@baryluk
Copy link
Owner

baryluk commented Dec 17, 2023

Hi @sheikhmishar

Thanks for the interest, and making it work on Windows. Cool you find it useful.

I would need to think if I want this code change in this repo. I despise Windows, and even a hint of code complication to support it would be reject. But your patch looks harmless enough, and does not have any OS detection, so should be easy to maintain. So maybe I could accept it.

I will get back to you after some more thinking.

@sheikhmishar
Copy link
Author

sheikhmishar commented Dec 17, 2023

You're most welcome. Previously I used OS detection. But, later realized that exclusive usb device access is kernel dependant. So, whether you're on linux or any other platform, the exception can occur anywhere. I've seen such crucial feature not implemented in linux based OSes on single board computers like bananaPi. So, whether you want Windows support or not, the exception handling should be added anyway

@sheikhmishar
Copy link
Author

Also, if we as developers really want to support the community, we cannot be so picky about things and despise an OS just because we personally don't like something about it. There are tons of great things in Windows and lots of which are nowadays integrated in linux based platforms. If Windows is a way to benefit people, who are we to do the gatekeeping???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants