Avoid echoing private key #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
commented
Mar 6, 2024
| @@ -3,4 +3,3 @@ BASE_CONTRACTS_COMMIT=fe492be3478134b2305c207a12b153eca04148c0 | |||
|
|
|||
| GUARDIAN=0xA9FF930151130fd19DA1F03E5077AFB7C78F8503 | |||
| OPTIMISM_PORTAL_PROXY=0x49f53e41452C74589E85cA1677426Ba426459e85 | |||
| GUARDIAN_PRIVATE_KEY= # TODO: Fill in when running script | |||
There was a problem hiding this comment.
avoid putting here because we don't want anybody to accidentally check this in
mdehoog
commented
Mar 6, 2024
| ## | ||
| # Incident response commands | ||
| # Note that --ledger --hd-paths <PATH> can be replaced with --private-key $(PRIVATE_KEY) | ||
| # in any command when using a local key. | ||
| ## | ||
|
|
||
| ifndef PORTAL_GUARDIAN_PRIVATE_KEY | ||
| $(error PORTAL_GUARDIAN_PRIVATE_KEY is undefined) | ||
| endif |
There was a problem hiding this comment.
signer can instead provide the key when calling make
mdehoog
commented
Mar 6, 2024
| # Pause OptimismPortal Commands | ||
|
|
||
| .PHONY: pause-portal-dryrun | ||
| pause-portal-dryrun: | ||
| @forge script --rpc-url $(L1_RPC_URL) \ |
There was a problem hiding this comment.
the @ prefix will avoid echoing the private key to stdout
nadir-akhtar-coinbase
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.