Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix imports and silence linter warnings for script files #118

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: fix imports and silence linter warnings for script files #118

merged 3 commits into from
Jan 22, 2025

Conversation

jackchuma
Copy link
Contributor

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 21, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

xenoliss
xenoliss previously approved these changes Jan 22, 2025
View reviewed changes
cbfyi
cbfyi previously approved these changes Jan 22, 2025
View reviewed changes
@cb-heimdall cb-heimdall dismissed stale reviews from cbfyi and xenoliss January 22, 2025 16:15

Approved review 2567641999 from cbfyi is now dismissed due to new commit. Re-request for approval.

@jackchuma jackchuma requested review from cbfyi and xenoliss January 22, 2025 16:22
@jackchuma jackchuma merged commit 07afeac into main Jan 22, 2025
2 checks passed
@jackchuma jackchuma deleted the jack/linter branch January 22, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbfyi cbfyi cbfyi approved these changes

@xenoliss xenoliss xenoliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackchuma @cb-heimdall @xenoliss @cbfyi