Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to ledger with latest firmware #12

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix access to ledger with latest firmware #12

merged 1 commit into from
Jan 7, 2025

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Jan 7, 2025

Can revert and use upstream implementation once ethereum/go-ethereum#31004 is merged.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 7, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog merged commit e6e3594 into main Jan 7, 2025
3 checks passed
@mdehoog mdehoog deleted the michael/fix-ledger branch January 7, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angel-ding-cb angel-ding-cb angel-ding-cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdehoog @cb-heimdall @angel-ding-cb