Skip to content

fix: improve browser compatibility for crypto.randomUUID() #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve browser compatibility for crypto.randomUUID() #65

wants to merge 1 commit into from

Conversation

aso20455
Copy link

Summary

Enhanced the check for window.crypto.randomUUID() to handle browsers that implement the Crypto API but don't support the randomUUID method

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 25, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

spencerstock
spencerstock approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@spencerstock spencerstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cb-heimdall
Copy link
Collaborator

Review Error for fan-zhang-sv @ 2025-07-25 15:46:58 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fan-zhang-sv fan-zhang-sv fan-zhang-sv approved these changes

@spencerstock spencerstock spencerstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aso20455 @cb-heimdall @fan-zhang-sv @spencerstock