[audit] #16: Bring SybilResistanceVerifier into compliance with EIP-191 #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
address(this)
to the expected signature hash.From Spearbit:
Description
As per EIP-191 the following bytes after
1900
should be the (i.e,address(this)
). This is done so that the signatures cannot be replayed across different contracts.The
SybilResistanceVerifier._makeSignatureHash
currently appends the signer address after1900
.Recommendation
Consider appending
address(this)
after1900
.