Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[audit2] Spearbit second audit #80

Merged
merged 9 commits into from
Jul 24, 2024
Merged

[audit2] Spearbit second audit #80

merged 9 commits into from
Jul 24, 2024

Conversation

stevieraykatz
Copy link
Collaborator

@stevieraykatz stevieraykatz commented Jul 22, 2024 •
edited
Loading

Individual findings and addressing PRs:

#71
#72
#73
#74
#75
#76
#77
#78
#81

@stevieraykatz
[audit2] #2 Typos and Documentation (#72)
0aa3e00 
* Fix typo in PaymentReceiverUpdated

* Fix typo in L2Resolver commment

* Fix typos in L2Resolver and ReverseRegistrar natspec

* Fix comment in IPriceOracle

* Fix natspec in controllers
@stevieraykatz
Remove unused event (#71)
75929f9
@stevieraykatz stevieraykatz changed the title Spearbit second audit [audit2] Spearbit second audit Jul 22, 2024
@stevieraykatz stevieraykatz marked this pull request as ready for review July 23, 2024 23:29
@cb-elileers cb-elileers self-requested a review July 24, 2024 00:18
cb-elileers
cb-elileers approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@cb-elileers cb-elileers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

     _~
  _~ )_)_~
  )_))_))_)
  _!__!__!_
  \______t/
~~~~~~~~~~~~~

Ship it

@cb-heimdall
Copy link
Collaborator

Review Error for cb-elileers @ 2024-07-24 00:21:27 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@stevieraykatz stevieraykatz merged commit 38c44ee into main Jul 24, 2024
5 of 7 checks passed
@stevieraykatz stevieraykatz deleted the Spearbit-second-audit branch July 24, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-elileers cb-elileers cb-elileers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevieraykatz @cb-heimdall @cb-elileers