Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for pre-minting basenames #83

Merged
merged 29 commits into from
Aug 24, 2024
Merged

Conversation

stevieraykatz
Copy link
Collaborator

This PR allows a permissioned wallet to register names against the BaseRegister. The wallet must be an approved controller on the BaseRegistrar.

We use the registerOnly method to generate an NFT without updating the registry. The NFTs generated are minted to the BASE_ECOSYSTEM_MULTISIG.

cb-elileers
cb-elileers previously approved these changes Jul 25, 2024
Copy link
Collaborator

@cb-elileers cb-elileers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure you remove the minting address as a controller when you're done.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 25, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall cb-heimdall dismissed cb-elileers’s stale review July 26, 2024 00:15

Approved review 2200386899 from cb-elileers is now dismissed due to new commit. Re-request for approval.

drain,24701708314572634357916250440134022151723757036256723111406180233023575726768
aggregate,102330316382983605854315020259007756269403317351933302774740449722392990073844
rodeo,47843225644331270063128493724511267146276014100898521270698446977699084126641
coln,52542356754606411786199551460370531840268728762863954976333291853326614804026
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coin phish names are in output, but not in any of the premint files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names (and some others we got from the product org ad-hoc) were minted by manually executing the Premint script.

@stevieraykatz stevieraykatz merged commit b2f909f into main Aug 24, 2024
6 checks passed
@stevieraykatz stevieraykatz deleted the add-premint-script branch August 24, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants