Patch Permissions guide and reference #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
fan-zhang-sv
previously approved these changes
Aug 14, 2025
| @@ -11,6 +11,11 @@ After the user signs the permission, the `spender` can initiate transfers within | |||
|
|
|||
| Read more about the Spend Permission Manager contract and supported chains on [GitHub](https://github.com/coinbase/spend-permissions). | |||
|
|
|||
| <Callout type="info"> | |||
| Spend Permissions are currently not available on Base App Mini Apps. | |||
| They will be supported in the future. | |||
There was a problem hiding this comment.
nit: i think we can say it positively "Spend Permissions for Base App Mini Apps are coming soon and will be supported in a future update."
cb-heimdall
dismissed
fan-zhang-sv’s stale review
Approved review 3121226071 from fan-zhang-sv is now dismissed due to new commit. Re-request for approval.
fan-zhang-sv
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?