Skip to content

Conversation

@AlexD10S
Copy link

This updates the Quickstart → Launch a token test example.

Following the guide: https://docs.base.org/get-started/launch-token#token-launch-platforms-on-base I got the error:

Ran 2 tests for test/MyToken.t.sol:MyTokenTest
[FAIL: `testFail*` has been removed. Consider changing to test_Revert[If|When]_Condition and expecting a revert] testFailMintExceedsMaxSupply() (gas: 0)
[FAIL: `testFail*` has been removed. Consider changing to test_Revert[If|When]_Condition and expecting a revert] testFailUnauthorizedMinting() (gas: 0)
Suite result: FAILED. 0 passed; 2 failed; 0 skipped; finished in 3.27ms (0.00ns CPU time)

Foundry removed support for testFail* tests. Tests should now explicitly expect reverts using vm.expectRevert(...) and use the test_Revert_* naming pattern e.g https://getfoundry.sh/forge/tests/writing-tests/

…m.expectRevert

Foundry v1.0 removed testFail* tests. This updates the Quickstart’s test examples to test_Revert_* and uses vm.expectRevert (string/custom-error) as recommended in the Foundry docs.
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 21, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@AlexD10S AlexD10S changed the title docs(quickstart): replace deprecated testFail* with test_Revert_* + vm.expectRevert docs(quickstart): replace deprecated testFail* with test_Revert_* + vm.expectRevert Oct 21, 2025
@AlexD10S AlexD10S changed the title docs(quickstart): replace deprecated testFail* with test_Revert_* + vm.expectRevert docs(quickstart): replace deprecated testFail* using test_Revert_* and vm.expectRevert Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants