Skip to content

Conversation

haardikk21
Copy link
Contributor

Closes #122

@danyalprout
Copy link
Collaborator

I haven't tested this out (so maybe wrong), but I wonder if we should configure this via these env vars.

This looks like it'll also cause it to be exposed elsewhere, e.g. metrics (setup).

@haardikk21
Copy link
Contributor Author

I haven't tested this out (so maybe wrong), but I wonder if we should configure this via these env vars.

This looks like it'll also cause it to be exposed elsewhere, e.g. metrics (setup).

These are compile time env vars (env! Macro) not runtime so i dont think those will work. Can test tmr

Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to figure out how to override the version tag on metrics, as that's what our internal dashboards use

@github-project-automation github-project-automation bot moved this to In Review in Project Tracking Oct 8, 2025
@haardikk21
Copy link
Contributor Author

Would be great to figure out how to override the version tag on metrics, as that's what our internal dashboards use

Ah I think we may actually be able to use https://github.com/paradigmxyz/reth/blob/6f96a328128eb79a3009669b0a32f232971a99c9/crates/node/core/src/version.rs#L15 to override it entirely on our own. I will do a separate PR and close this one once I can test it works.

@haardikk21 haardikk21 closed this Oct 9, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Oct 9, 2025
@haardikk21 haardikk21 deleted the clientversion-override branch October 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override version reported by Reth to include node-reth version as well
2 participants