fix: Preload txn receipt from eth_api for historical deposit txns #28
+385
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
reviewed
May 13, 2025
jowparks
reviewed
May 13, 2025
|
The codebase has several other places where unsafe |
jowparks
reviewed
May 13, 2025
jowparks
reviewed
May 13, 2025
| @@ -387,7 +395,41 @@ where | |||
| block_number: Some(block_number), | |||
| base_fee, | |||
| }; | |||
| Ok(Some(self.transform_tx(transaction, tx_info))) | |||
| // preload transaction receipt if it's a deposit transaction | |||
| if transaction.is_deposit() { | |||
There was a problem hiding this comment.
Why did all this move to this method and pass in the receipt? Why not keep this logic in the transform_tx and prevent the addition of the receipt param? That way if the method is used anywhere else we won't have to replicate this logic. Otherwise looks good
There was a problem hiding this comment.
pretty much to avoid marking a bunch of other functions async because rust has colored functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flashblocks RPC had a bug where it would panic if
getTransactionByHashwas used to load historical deposit transactions.These transactions did not exist in the mempool (system transaction) and did not exist in the cache (historical transaction) but in the case of deposit transactions we would always try to fetch a receipt from the cache to populate
deposit_receipt_versionanddeposit_nonce.Since we did
unwrap()without an error check in that path, it would cause a panic.This PR attempts to fix that by pre-loading the deposit transaction receipt from
eth_apiin case a historical deposit transaction is attempted to be fetched viagetTransactionByHash.P.S. Opened this PR as the forked repo PR did not allow me to trigger a
base-buildssepolia alpha deployment to test without more changes than necessary to those Dockerfiles.Edit; ignore the branch name. i thought the root cause was a race condition, it was not.