Skip to content

Conversation

dxbr
Copy link

@dxbr dxbr commented Sep 15, 2025

Description

This update addresses an issue in the dependency updater where commit titles and descriptions were generated in a nondeterministic order due to iterating over a Go map.
The changes ensure that dependency updates are alphabetically sorted before composing commit metadata, resulting in stable, predictable commit messages.
Unit tests have been added to verify deterministic formatting and to ensure the original dependency slice is not mutated.

Summary

  • Ensure the dependency updater builds commit titles and descriptions from a stable, alphabetically sorted dependency list.
  • Add unit tests that exercise deterministic formatting behavior and guard against slice mutation.

Testing

  • go test ./...

Notes

These improvements guarantee consistent commit messages across runs, improving traceability, CI reliability, and reducing random diffs in automated dependency updates.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the PR. Would you be able to rebase/update the content to match this PR. Thanks!

@cb-heimdall
Copy link
Collaborator

Review Error for danyalprout @ 2025-10-09 04:10:38 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants