Fix stack overflow from O(len(changes)) recursion depth #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
jjtny1
reviewed
Apr 22, 2025
| let first_non_delete_idx = match first_non_delete_idx { | ||
| None => return Ok(PointerChange::None), | ||
| Some(idx) => idx, | ||
| }; |
There was a problem hiding this comment.
Why is this not being caught by the current code? Is it stack overflow?
There was a problem hiding this comment.
I think we don't have unit tests or benchmarks which requires deleting many non-existing values in a single transaction until #106 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #106 (comment)
TODO: